Skip to content

Update Microsoft.WindowsAppSDK to 1.8 stable#790

Open
Arlodotexe wants to merge 7 commits intomainfrom
wasdk1.8
Open

Update Microsoft.WindowsAppSDK to 1.8 stable#790
Arlodotexe wants to merge 7 commits intomainfrom
wasdk1.8

Conversation

@Arlodotexe
Copy link
Copy Markdown
Member

@Arlodotexe Arlodotexe commented Mar 30, 2026

This PR upgrades our tooling, components, and dependencies to the 1.8 version of the Windows App SDK.

The changes here have had basic builds/tests run locally, and fixes several of the build issues encountered while trying to build WASDK under the new version.

Remaining uncertainty:

  • The errors in the tooling CI are caused by a package reference to an old version of the toolkit using older versions of WADSK, particularly we noted CommunityToolkit.Common (and will check for more).

Prerequisites:

  • The PR at Upgrade WASDK from 1.6 to 1.8 Tooling-Windows-Submodule#293 needs to be merged before this PR can be closed.
  • Before we can close this PR, we'll need to use the PR nuget feed here to ship a prerelease update to any toolkit components that are referenced in the gallery by our tooling.
    • This is a recurring requirement any time we update the toolkit's dependencies, it also happened with our upgrade to 1.6.
    • Generally, this friction is being recorded for possible improvements via proper toolkit-using-toolkit tooling.

@Arlodotexe Arlodotexe self-assigned this Mar 30, 2026
@michael-hawker
Copy link
Copy Markdown
Member

michael-hawker commented Apr 8, 2026

Supersedes #738? @Arlodotexe you were going to make Rive not build for WASDK which should resolve the build/dependency issues for now, eh?

@Arlodotexe
Copy link
Copy Markdown
Member Author

Arlodotexe commented Apr 8, 2026

@michael-hawker Ah, I hadn't seen 738 or I would have reused it like I did with the tooling submodule PR.

Since this PR is ready to go, we'll have it supersede #738.

@Arlodotexe Arlodotexe mentioned this pull request Apr 8, 2026
Closed
@Arlodotexe
Copy link
Copy Markdown
Member Author

Arlodotexe commented Apr 8, 2026

We'll also want to update both Labs and the tooling submodule to use the latest preview2 packages, that's next.

@Arlodotexe
Copy link
Copy Markdown
Member Author

Arlodotexe commented Apr 8, 2026

Noting the WASDK error here:

       "D:\a\Labs-Windows\Labs-Windows\CommunityToolkit.AllComponents.sln" (default target) (1:2) ->
       "D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\Tests.Wasdk\CommunityToolkit.Tests.Wasdk.csproj" (default target) (39:6) ->
       (XamlPreCompile target) -> 
         D:\a\Labs-Windows\Labs-Windows\components\TitleBar\tests\ExampleTitleBarTestClass.cs(18,31): error CS0104: 'TitleBar' is an ambiguous reference between 'CommunityToolkit.WinUI.Controls.TitleBar' and 'Microsoft.UI.Xaml.Controls.TitleBar' [D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\Tests.Wasdk\CommunityToolkit.Tests.Wasdk.csproj]
         D:\a\Labs-Windows\Labs-Windows\components\TitleBar\tests\ExampleTitleBarTestClass.cs(19,44): error CS0104: 'TitleBar' is an ambiguous reference between 'CommunityToolkit.WinUI.Controls.TitleBar' and 'Microsoft.UI.Xaml.Controls.TitleBar' [D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\Tests.Wasdk\CommunityToolkit.Tests.Wasdk.csproj]
         D:\a\Labs-Windows\Labs-Windows\components\TitleBar\tests\ExampleTitleBarTestClass.cs(22,32): error CS0104: 'TitleBar' is an ambiguous reference between 'CommunityToolkit.WinUI.Controls.TitleBar' and 'Microsoft.UI.Xaml.Controls.TitleBar' [D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\Tests.Wasdk\CommunityToolkit.Tests.Wasdk.csproj]
         D:\a\Labs-Windows\Labs-Windows\components\TitleBar\tests\ExampleTitleBarTestClass.cs(49,29): error CS0104: 'TitleBar' is an ambiguous reference between 'CommunityToolkit.WinUI.Controls.TitleBar' and 'Microsoft.UI.Xaml.Controls.TitleBar' [D:\a\Labs-Windows\Labs-Windows\tooling\ProjectHeads\AllComponents\Tests.Wasdk\CommunityToolkit.Tests.Wasdk.csproj]

This must be because TitleBar is available in WASDK now, and it's just conflicting with our labs component.

I can fix this locally.

@michael-hawker
Copy link
Copy Markdown
Member

michael-hawker commented Apr 9, 2026

@michael-hawker Ah, I hadn't seen 738 or I would have reused it like I did with the tooling submodule PR.

Since this PR is ready to go, we'll have it supersede #738.

Ah, ok, just making sure. You can always list Adam as a co-author in one of your commit messages for updating the tooling or something so that he gets the credit still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Arlodotexe Arlodotexe

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Arlodotexe @michael-hawker